-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added size parameter which should result in original scale crops. #400
base: master
Are you sure you want to change the base?
Conversation
@jimmyff just curious what do you use instead? |
It should work according to the docs but it still was giving me crops too small. I opened an issue at croppies end: Foliotek/Croppie#786 (although Croppie seems like an unmaintained project)
As well as the crop size bug I was also getting weird UI issues with this plugin web integration so I'm currently using It's a shame this plugin doesn't nail the web cropping as the iOS and Android integrations are great. |
@hnvn maybe switching to a different library could make sense here? |
Maybe replacing croppie is too drastic and the integration issues could be fixed? It seems like the implmentation is almost there but for my particular purpose on this occassion I was hoping for something working off the shelf. A quick look on gitthub and https://github.com/fengyuanchen/cropperjs is the most popular project by some margin. It seems very active with a v2 branch currently in alpha. |
Hm not sure, if in the long term it is easier to maintain since the library is better maintained it may make thinks easier in the long run and brings web to the same level as mobile integrations are. cropperjs looks like a good choice saw an issue opened last week and a reply from the developer. While Croppie it looks like it's unmaintained. |
I am facing these exact issues, going to attempt to integrate cropperJS to my Flutter web project. Real shame this isn't maintained. update: Use this for web https://pub.dev/packages/crop_your_image |
PLEASE!!! Croppie is so bad right now |
Added the
size
parameter set tooriginal
as described in http://foliotek.github.io/Croppie/#documentation to get full size crops rather than crops sized at viewport scale.I've moved on from this plugin as the web implementation doesn't seem to be at the same level as ios & android.
#399 (comment)